videojs/video.js

Volume/Mute State Not Preserved Switching Between HTML5 and Flash Techs

Open

#2,066 opened on Apr 23, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (7,502 forks)batch import
confirmedgood first issuepinnedunclaimed

Repository metrics

Stars
 (39,742 stars)
PR merge metrics
 (Avg merge 111d 10h) (3 merged PRs in 30d)

Description

I see 2 problems with volume/mute handling in videojs:

  1. Html5 and Flash tech are inconsistent handling volume and muted. Html5 maintains 2 separate variables to hold the value for volume() and muted(). Flash on the other hand sets volume = 0 when muted(true) is called. My guess is Html5 is the proper implementation desired.
  2. The state stored for volume() and muted() are delegated to the Tech. Switching between Techs causes volume and muted states to be lost between the time unloadTech and loadTech is called. A simple hack is to add a couple lines inside loadTech to save the state of muted and volume and then reapply those states inside the techReady function. Going forward, I feel the Player core should hold these states.

I'm working off a modified version of v4.12.5

Contributor guide

Research direction
Investigate the volume and muted state handling in both HTML5 and Flash techs. Review the tech switching logic in player.js, specifically the unloadTech and loadTech methods. Propose a solution to store these states in the Player core rather than delegating to the tech.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60