videojs/video.js

Html5 src behaves incorrectly

Open

#1169 opened on Apr 25, 2014

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (39,742 stars) (7,502 forks)batch import
bugconfirmedgood first issuepinnedunclaimed

Description

If one calls player.src() the current code for Html5 media will actually overwrite the src on the video rather than appropriately return src or return currentSrc

Contributor guide

Tech stack
javascript
Domain
apifrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with JavaScriptUnderstanding of getter/setter behaviorBasic knowledge of video.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the current implementation of the src method in media/html5.js. Investigate how the getter and setter are separated (possibly using a getter/setter pattern). The fix likely involves ensuring that calling src() with no arguments returns currentSrc instead of setting the src attribute. Review the discussion in the issue comments for any proposed solutions. Check for any related tests in test/ directory.