victorb/autochecker

Build Docker image from current directory

Open

#21 opened on Apr 26, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (601 stars) (22 forks)batch import
enhancementhelp wanted

Description

I have a rather large project directory due to lots of build products, which means all of those are copied into the temporary directory by copyApplicationToTempLocation(). At first glance it appears this only exists such that it excludes .git and node_modules directories by default. There's a TODO in there for this to be more language independent, so I think the best path forward is to encourage users to create their own .dockerignore file, perhaps suggesting to generate one by default if one does not yet exist.

The Dockerfile built from the template could be put into a temp file since Docker supports specifying alternative files to build from.

Contributor guide

Tech stack
dockerjavascript
Domain
build systemdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
DockerJavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the 'copyApplicationToTempLocation' function in the codebase to understand how it currently copies files. Look for the TODO comment mentioned in the issue. Investigate how to generate a default .dockerignore file if one does not exist, and consider modifying the Dockerfile to use a temporary file as suggested.