vgstation-coders/vgstation13

Breach not leaking air on BOX in escape

Open

#18,134 opened on Apr 22, 2018

View on GitHub
 (4 comments) (0 reactions) (1 assignee)DM (272 stars) (552 forks)batch import
Help Wanted

Description

Description of issue

Breach in escape to space with just a broken grill that was not leaking atmos https://i.imgur.com/jytPhH0.png

Difference between expected and actual behavior

should have been zas hell

Steps to reproduce

see picture

Specific information for locating

Length of time in which bug has been known to occur

Server revision

Game: 6b4e59dc054768db5b4556a72a268c17f26549b4 Patches: f7b1883a4643b40f0e4c1aa07538e4260810a476

Issue bingo

Please check whatever applies. More checkboxes checked increase your chances of not being yelled at by every contributor.

  • Issue could be reproduced at least once
  • Issue could be reproduced by different players
  • Issue could be reproduced in multiple rounds
  • Issue happened in a recent (less than 7 days ago) round
  • Couldn't find an existing issue about this

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Atmos system knowledgeDM programming basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the atmos system code, particularly the handling of grills and breaches. Check if there is a missing check for grill integrity when calculating air loss. Look for any recent changes that might have introduced this bug. Consider reproducing the issue in a local environment.