vesoft-inc/nebula

enhance for "if not exists"

Open

#1,591 opened on Jan 6, 2020

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (1,144 forks)batch import
good first issueneed to discusstype/enhancement

Repository metrics

Stars
 (9,828 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

  1. create an edgetype with prop
> create edge choose(grade int)
  1. create the edgetype without any prop using if not exists
> create edge if not exists choose()
Execution succeeded (Time spent: 12.129/13.466 ms)
  1. check the schema of choose
describe edge choose;
================
| Field | Type |
================
| grade | int  |
----------------
Got 1 rows (Time spent: 13.604/15.04 ms)

In step 2, maybe "the edgetype exists, we will not create" is more user-friendly than "Execution succeeded"

Contributor guide

Research direction
Locate the code that handles 'CREATE EDGE IF NOT EXISTS' and change the success message to indicate that the edge type already exists.
Tech stack
c
Domain
databasebackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80