vercel/serve

Allow removal of a header

Open

#438 opened on Jun 21, 2018

View on GitHub
 (8 comments) (2 reactions) (0 assignees)TypeScript (719 forks)batch import
help wantedpatch

Repository metrics

Stars
 (8,811 stars)
PR merge metrics
 (Avg merge 45d 1h) (2 merged PRs in 30d)

Description

I'd like to be able to set a default header and then override it to nonexistance. When I do the below, a header with null shows up, versus the header disappearing. Ditto with max-age=0. And when I do "headers": [], it gets 86400 from the first rule.

image

image

cc @leo

Contributor guide

Research direction
Examine the header handling in the codebase and implement a way to remove a header by setting it to null or empty string, ensuring that the default header is overridden correctly.
Tech stack
typescriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75