vercel/serve

Allow removal of a header

Open

#438 opened on Jun 21, 2018

View on GitHub
 (8 comments) (2 reactions) (0 assignees)TypeScript (8,811 stars) (719 forks)batch import
help wantedpatch

Description

I'd like to be able to set a default header and then override it to nonexistance. When I do the below, a header with null shows up, versus the header disappearing. Ditto with max-age=0. And when I do "headers": [], it gets 86400 from the first rule.

image

image

cc @leo

Contributor guide

Tech stack
typescriptnodejs
Domain
backendcli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic HTTP headers knowledgeNode.js environmentServe project setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the serve source code, particularly the header handling middleware and configuration schema. Look for how default headers are applied and if there is existing logic for overriding. Check the comments on this issue for any proposed solutions. Consider modifying the configuration parsing to allow an empty value or special key to remove a header.