vercel/serve

Make redirections support query strings

Open

#393 opened on May 30, 2018

View on GitHub
 (6 comments) (5 reactions) (0 assignees)TypeScript (8,811 stars) (719 forks)batch import
help wantedpatch

Description

I've been using version 6.5.8 and I was able to serve URLs with query string, example: http://localhost:5000/code.html?26482

The query string "?26482" is missing a parameter name, and that's intentional because it's the only way it works.

Adding the parameter causes it to serve without the query string, try: http://localhost:5000/code.html?id=26482 for instance.

When updated to version 7, none of this works (with parameter and without parameter).

Contributor guide

Tech stack
typescriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Node.jsUnderstanding of HTTP query strings
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how `serve` handles redirects, particularly the logic that constructs redirect URLs. Look in the source code for middleware or route handling that deals with query strings. Check if the issue is related to how the `Content Type` or `Location` headers are set during redirects. Review the comments for any hints about the expected behavior.