vercel/release

Only commit package.json instead of all files

Open

#162 opened on Aug 22, 2019

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (3,534 stars) (145 forks)batch import
bughelp wanted

Description

Is it viable to just add package.json after bumping version instead making a git add -A? I can send the PR myself

https://github.com/zeit/release/blob/0b421e071e9bcbf66bbfe4702a0743145260ac1e/lib/bump.js#L112

cc @leo

Contributor guide

Tech stack
javascriptnodejs
Domain
clitoolingrelease
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The fix is in lib/bump.js line 112, where `git add A` is currently used. Change it to only stage `package.json`. Verify that no other files are needed (e.g., package lock.json) and check if the maintainer has responded to the cc. The issue is from 2019, so confirm the current codebase state and if any related changes have been made.