vercel/next.js

`@next/next/no-html-link-for-pages` rule does not work with `pageExtensions`

Open

#53473 opened on Aug 2, 2023

View on GitHub
 (35 comments) (0 reactions) (0 assignees)JavaScript (139,471 stars) (31,066 forks)batch import
Lintinggood first issue

Description

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000
    Binaries:
      Node: 18.14.2
      npm: 9.8.1
      Yarn: 1.22.19
      pnpm: 8.3.1
    Relevant Packages:
      next: 13.4.13-canary.9
      eslint-config-next: 13.4.12
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.3
    Next.js Config:
      output: N/A

Which area(s) of Next.js are affected? (leave empty if unsure)

ESLint (eslint-config-next)

Link to the code that reproduces this issue or a replay of the bug

https://github.com/nnmax/next-eslint-config-reproduction-app

To Reproduce

  1. git clone https://github.com/nnmax/next-eslint-config-reproduction-app.git
  2. cd next-eslint-config-reproduction-app
  3. npm install
  4. npm run lint
  5. Observe the ESLint output from the terminal.

Describe the Bug

The @next/next/no-html-link-for-pages rule doesn't work after configuring custom pageExtensions.

Expected Behavior

It should recognize pageExtensions.

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Contributor guide

Tech stack
javascriptreactnextjs
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Next.js configurationFamiliarity with ESLint plugin code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the ESLint rule `no html link for pages` in the Next.js repository (packages/eslint config next). Understand how it currently reads `pageExtensions` and why it fails with custom values. Review the reproduction repository and comments in the issue for any proposed fixes. Consider implementing a change to read the custom `pageExtensions` from the user's Next.js config (e.g., using `require` or passing config via ESLint settings).