vercel/hyper

Prompt before closing the app when a process is running

Open

#684 opened on Sep 2, 2016

View on GitHub
 (20 comments) (10 reactions) (0 assignees)TypeScript (44,582 stars) (3,558 forks)batch import
good first issuehelp wanted🛠 Type: Feature Request

Description

Related to #623. Would it be possible to have a prompt before quitting the app when a process is running? It could help to prevent quitting the app with an ongoing process that we won't be able to kill without manually killing the PID.

Contributor guide

Tech stack
typescriptelectron
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Electron app lifecycleHyper's main process architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the current behavior of the app's close event in the main process (likely in `app/main.ts` or similar). Look at the linked issue #623 for context. Consider implementing a confirmation dialog using Electron's `dialog` module or custom UI. Review how the app tracks running processes to conditionally show the prompt.