vercel/hyper

ctrl+shift commands aren't working

Open

#2837 opened on Apr 16, 2018

View on GitHub
 (3 comments) (4 reactions) (0 assignees)TypeScript (44,582 stars) (3,558 forks)batch import
help wanted

Description

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: 10.13.4 macOS

  • Hyper.app version: 2.0.0

Issue

ctrl+shift commands don't seem to work anymore. In emacs for example, undo is ctrl+_ which requires the shift and ctrl key to be pressed at the same time.

Contributor guide

Tech stack
typescriptjavascriptnodejs
Domain
desktopcli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScript knowledgeUnderstanding of keyboard events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the keyboard input handling code in Hyper, specifically in the main process or renderer. Look at the keydown event listeners and how modifier keys (ctrl, shift) are processed. Check for any changes in Electron's keyboard event handling that could cause this regression. Review the existing comments on the issue for any additional context or attempted fixes.