vercel/hyper

Reload causes New Tab to spawn multiple tabs

Open

#2652 opened on Feb 1, 2018

View on GitHub
 (3 comments) (3 reactions) (0 assignees)TypeScript (44,582 stars) (3,558 forks)batch import
help wanted🐛 Type: Bug

Description

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: MacOS 10.13.3

  • Hyper.app version: 2.0.0.canery11

  • Link of a Gist with the contents of your .hyper.js: Link

  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): On each Reload a message (re)loading renderer plugins appears for each Reload that I have done (exponential growth)

  • The issue is reproducible in vanilla Hyper.app: yes, I don't use plugins

Issue

  1. Open a new Hyper Window
  2. Reload the Tab (e.g. by pressing Ctrl+R)
  3. Open a new Tab (e.g. by pressing Ctrl+T)
  4. Two new tabs open
  5. Reload the Tab (e.g. by pressing Ctrl+R)
  6. Open a new Tab (e.g. by pressing Ctrl+T)
  7. Three new tabs open ...

Contributor guide

Tech stack
typescriptjavascriptelectronnodejshtmlcss
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ElectronEvent handlingHyper internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the tab creation logic in the renderer process. Focus on event listeners that register on each reload, causing duplicate new tab handlers. Check the 'newTab' action and ensure listeners are properly cleaned up on reload. This bug is likely in the renderer's initialization code.