vercel/hyper

Cannot clear terminal with Command+K since latest version (1.3.2.1744)

Open

#1,808 opened on May 10, 2017

View on GitHub
 (33 comments) (34 reactions) (0 assignees)TypeScript (3,558 forks)batch import
help wanted

Repository metrics

Stars
 (44,582 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: macOS Sierra Version 10.12.2
  • Hyper.app version: Version 1.3.2 (1.3.2.1744)
  • Link of a Gist with the contents of your .hyper.js: Link
  • Relevant information from devtools No errors in console.
  • The issue is reproducible in vanilla Hyper.app: The only plugin I have is a theme.

Issue

Ever since the latest update, it seems I can't clear the terminal with command+K. This issue only happens when I have done npm start to start webpack for one of my apps. Currently, whenever I press command+K, it makes ^L appear at the bottom of the terminal.

Here is a screenshot of the issue: (You can see the ^L come everytime I try to clear at the bottom):

screen shot 2017-05-10 at 4 43 27 am

EDIT: Just to provide some more info, if I exit out of the process with control+C, and then run the clear with command+K it works fine.

Contributor guide

Research direction
Investigate how Command+K keybinding is handled in Hyper's terminal emulator. Look at the code that processes key events, especially when a process is running. Check if the key event is being intercepted or sent to the process as input. Compare behavior with and without a running process.
Tech stack
typescriptjavascriptnodejs
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaScriptElectron basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55