vercel/hyper

Shell changes not honored until logging out of OS X

Open

#147 opened on Jul 16, 2016

View on GitHub
 (4 comments) (6 reactions) (0 assignees)TypeScript (44,582 stars) (3,558 forks)batch import
help wanted🐛 Type: Bug

Description

If on bash: chsh -s /bin/zsh && exit If on zsh: chsh -s /bin/bash && exit

When you reopen Hyperterm.app the shell will have not changed. This is not the default behaviour of Terminal.app or iTerm.app.

Contributor guide

Tech stack
typescriptshell
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with macOS shell configurationbasic understanding of Electron/Node.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate how Hyper spawns the shell process. The issue is that changes via `chsh` are not reflected until logout. Look at the shell spawn logic in Hyper's source, likely in `src/shell.js` or similar, and check if it uses `process.env.SHELL` or reads `/etc/shells`. The fix may involve re reading the user's shell configuration at startup or after a change. Check if there is an existing PR or discussion addressing this.