vectordotdev/vector

metrics: rename memory enrichment table counters to end with _total

Open

#25455 opened on May 18, 2026

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (21,837 stars) (2,126 forks)batch import
domain: enrichment_tablesdomain: metricsgood first issuesource: internal_metrics

Description

Summary

Three counter metrics in the memory enrichment table are missing the _total suffix, violating the instrumentation spec.

From docs/specs/instrumentation.md: "Counters MUST end with total"

Metrics to rename

Current name Correct name
memory_enrichment_table_failed_insertions memory_enrichment_table_failed_insertions_total
memory_enrichment_table_failed_reads memory_enrichment_table_failed_reads_total
memory_enrichment_table_ttl_expirations memory_enrichment_table_ttl_expirations_total

These are defined in lib/vector-common/src/internal_event/metric_name.rs as CounterName variants. Their descriptions already say "The total number of..." confirming the intent was to follow the _total convention.

Notes

These are breaking changes for anyone scraping these metrics directly. The old names should be kept as deprecated aliases or the rename should be accompanied by a changelog entry.

Contributor guide

Tech stack
rust
Domain
observability
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingVector internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The issue involves renaming CounterName variants in lib/vector common/src/internal event/metric name.rs. The specification in docs/specs/instrumentation.md requires counters to end with ' total'. The renames are straightforward. The issue suggests keeping old names as deprecated aliases or adding a changelog entry, which should be considered but is not required for the core fix.