vanhauser-thc/thc-hydra

[BUG] When resuming a session, finished tries count towards new session tries - messing up ETA

Open

#824 opened on Feb 19, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (1,913 forks)batch import
best practicegood first issuehelp wanted

Repository metrics

Stars
 (8,689 stars)
PR merge metrics
 (Avg merge 2d 14h) (2 merged PRs in 30d)

Description

I left a session running for about 10 minutes during which ~9000 tries were done. Then I remebered to add -f option so I stopped the execution and resumed it using -R with the added option. Now after 1 minute I get: [STATUS] 10166.00 tries/min, 10166 tries in 00:01h, 989834 to do in 01:38h, 32 active even though the actual speed is somewhere around(from the previous session): [STATUS] 634.00 tries/min, 634 tries in 00:01h, 999366 to do in 26:17h, 32 active

With time due to averaging it does converge towards the actual speed but I believe this is undesired.

Contributor guide

Research direction
Inspect the session resume code path and how finished tries are tracked; ensure that when resuming, only new tries are counted for ETA calculations.
Tech stack
c
Domain
clisecurity
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75