valyala/fasthttp

Request loses host information after calling RequestURI method

Open

#895 opened on Oct 28, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
help wanted

Description

Hello,

First, I would like to thank you for this awesome library.

I'm not sure if this is an issue but I noticed this. On the Request struct, il you call the RequestURI method, the Host method won't return anything after that.

It is really easy to reproduce :

package main

import (
	"github.com/valyala/fasthttp"
)

func main() {
	request := &fasthttp.Request{}
	request.SetRequestURI("http://example.com/test-1")

	println(string(request.Host()))
	println(string(request.RequestURI()))
	println(string(request.Host()))
}

This outpouts :

example.com
/test-1

As it should oupout in my opinion :

example.com
/test-1
example.com

For those who could experience the same issue, a workaround is to call instead :

request.URI().RequestURI()

But I would like to know if this is an issue or if this is the normal behavior. If this is the normal behavior, it should probably be documented :) Otherwise, I might be able to send you a PR to fix this if you want.

Thank you in advance for your help.

Contributor guide

Tech stack
go
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingfasthttp library basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The bug is in the RequestURI method, which seems to modify the internal URI representation causing Host() to return empty after the call. Investigate the implementation of RequestURI in the fasthttp package, specifically how it sets the request URI and whether it properly preserves the host information. Check the URI struct and the Host method to understand the data flow. Look at existing tests for URI handling and consider creating a minimal reproduction test. The fix likely involves ensuring that setting the request URI updates the host field accordingly.