valyala/fasthttp

How to integrate fasthttp client with opentracing gracefully

Open

#775 opened on Apr 7, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
help wanted

Description

net/http expose RoundTrip so it can integrate with opentracing by overwrite the RoundTrip function. while fasthttp client don't implement such interface and do not provide middleware. The only way to integrate with opentracing is overwrite all method of fasthttp client, but it is not graceful.

Contributor guide

Tech stack
go
Domain
backendobservability
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingKnowledge of OpenTracing conceptsFamiliarity with fasthttp client
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue requests a graceful way to integrate OpenTracing with the fasthttp client, similar to net/http's RoundTrip mechanism. Research the net/http opentracing integration in opentracing contrib/go stdlib (nethttp/client.go) to understand the approach. Examine fasthttp's client source code (client.go) to identify where a middleware or interceptor could be added without compromising performance. Consider designing a client wrapper or method level hooks. Discuss the proposed design with maintainers in the issue comments.