valyala/fasthttp

how should convert bytesBuffer into http message object。

Open

#763 opened on Mar 13, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
help wanted

Description

i learned code below。

func (req *Request) Read(r *bufio.Reader) error {
	return req.ReadLimitBody(r, 0)
}

param r is io buf reader which could be a connection or something else。 i have a scene： goroutine read connection which is a very low eventloop with a fixed size of buffer，i dont wanna chang it。maybe i just get part of http bytes，not a complete http bytes，like chunk。 i cannot use Read method up there。 i did some research，netty has byteToMessageDecoder、envoy use http-parser （c++）https://github.com/nodejs/http-parser can we have this design future？

Contributor guide

Tech stack
go
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Knowledge of GoHTTP protocolFamiliarity with fasthttp internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the request for a byte to HTTP message decoder in fasthttp, similar to netty's ByteToMessageDecoder in Java or nodejs/http parser. Review the existing fasthttp codebase, especially the Request.Read method in fasthttp/http.go and the bufio.Reader usage. Check related comments in the issue for maintainer feedback. Look at Go standard library's net/http parser for inspiration. The issue is from 2020 and stale, so no active discussion; the task is to design a streaming HTTP parser that works with partial byte buffers.