valyala/fasthttp

add a IP addr in this error for locating issues faster?

Open

#732 opened on Jan 19, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
help wanted

Description

https://github.com/valyala/fasthttp/blob/03813ae4bce8b5984118f62d5f017da3e87c9189/tcpdialer.go#L365

usually, dialing a host, that resovle to mullti ips. and If include the IP information in this ErrDialTimeout, we can know which server is the problem faster.

Contributor guide

Tech stack
go
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Go knowledgefamiliarity with fasthttp tcpdialer.go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Locate the file tcpdialer.go at line 365 in the fasthttp repository. The ErrDialTimeout error message currently includes the host but not the IP address that was being dialed. Modify the error to include the resolved IP address (e.g., add a parameter for the IP). Check the DialTimeout function to see how it gets the addresses and pass the IP to the error string. No linked PRs or assignees found; this issue is open for contribution.
add a IP addr in this error for locating issues faster? · valyala/fasthttp#732 | Good First Issue