valyala/fasthttp

Recommendation on cleaning of HostClient.

Open

#726 opened on Jan 12, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
help wantedquestion

Description

As of now the only way to override Host header is to use HostClient as per Issue 318. This means we have to manage reusing/cleanup of HostClients ourselves which fasthttp.Client provided out of the box.

We will be writing something very similar to fasthttp.Client to handle this. Is it ok to remove the HostClient if it is not being used from more than MaxIdleConnDuration*2 or something, as we are sure all goroutines for individual connection cleaning would have run? We don't have access to connsCount as it is an unexported field and was modified to use connsCount instead of time.

if t.Sub(v.LastUseTime()) > (MaxIdleConnDuration*2) {
				delete(m, k)
			}

If not, what is the recommendation here?

Contributor guide

Tech stack
go
Domain
backendapi
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of GoFamiliarity with fasthttp client internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the fasthttp client code, specifically client.go lines 450-452 and 463-465, and the commit aebec409b. Determine if using MaxIdleConnDuration*2 as a timeout for removing unused HostClients is safe, considering goroutine cleanup timing. Also consider if there is a need to expose connsCount or provide a dedicated cleanup method for HostClients.