valyala/fasthttp

Request should not fail on small ReadBufferSize

Open

#1873 opened on Sep 24, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
help wantedwontfix

Description

Can we not fail request if the req/resp header size is greater than the read buffer size.

I can see a bufio bug was mentioned for tryRead function but looks like it's resolved now. Can we have the above mentioned behaviour?

Also, some callback could also be configured to inform that buffer size was low. Library users could emit metrics and increase the buffer size appropriately to have best balance between memory usage and CPU usage.

@valyala Could you review the request?

Contributor guide

Tech stack
gorest api
Domain
backendperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of GoFamiliarity with fasthttp's bufferingReading header.go file
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
First, read the fasthttp header.go file, especially the tryRead function at line 2128 and the surrounding buffer logic. Understand how ReadBufferSize affects request parsing. The issue references a Go bug (golang/go#14121) which is already resolved; investigate if that resolution can be applied to fasthttp. Additionally, consider implementing a callback mechanism to inform users when buffer size is low, allowing them to adjust. Check the existing comments for any maintainer feedback or additional context.