valyala/fasthttp

Add more functions to ease use of trailing headers

Open

#1401 opened on Oct 20, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
feature requesthelp wanted

Description

It is great that recent versions of fasthttp have trailer support, but it is more difficult and awkward to use. We should have minimal features like so:

  • PeekTrailer
  • PeekAllTrailer see #1394

It is tricky because SetTrailer isn't setting for a single value, rather all values. It would be nicer to have parity for apis to set/add and del, as well.

See https://github.com/mosn/pkg/issues/66

Contributor guide

Tech stack
go
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingHTTP protocol basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests new trailer functions (PeekTrailer, PeekAllTrailer) to improve usability. Reference existing issue #1394 and the external mosn/pkg issue for context. Study current trailer implementation in fasthttp (e.g., Response.SetTrailer), then implement the requested peek functions and potentially set/add/del parity functions. Ensure API consistency and performance.