valyala/fasthttp

client: set response body as net.Buffers

Open

#1161 opened on Nov 15, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
enhancementhelp wanted

Description

The net.Buffers internally uses writev syscall so we can write multiple chunks without concatenation in buffer. This significantly improves performance and I wondered why fasthttp doesn't use it.

Contributor guide

Tech stack
go
Domain
performance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Gofasthttpnet.Buffers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue suggests using net.Buffers to improve performance of writing response body in the client. The contributor should examine the fasthttp client code, specifically how the response body is written (likely in response.go or client.go files). They should implement using net.Buffers to batch write buffers without concatenation. There are no linked PRs, but the maintainer's comments (if any) should be reviewed. Testing for performance improvement and correctness is needed.