valyala/fasthttp

Chunked response with trailer result in "cannot find crlf at the end of chunk" error

Open

#1078 opened on Aug 21, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (21,741 stars) (1,755 forks)batch import
help wanted

Description

Hello,

While using fasthttp.Client to talk to a server that produce chunked response with trailer headers I see "cannot find crlf at the end of chunk" error. I suspects that this happens because fasthttp's implementation does not expect to see trailer headers after the last chunk, which is not according to chunked transfer coding spec.

This can ideally be fixed by adding https://github.com/valyala/fasthttp/issues/210. Otherwise readBodyChunked need to be mindful of trailers.

Let me know if I should produce an example.

Regards.

Contributor guide

Tech stack
go
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
HTTP chunked transfer encodingGo language basicsfasthttp library structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the chunked transfer encoding RFC and the `readBodyChunked` function in `http.go` or similar file. Investigate how trailers are currently handled and whether the fix from issue #210 (trailer support) can be integrated. Consider adding logic to parse trailer headers after the terminating chunk.