valkey-io/valkey

Updated CI testing to improve catching tests early.

Closed

#625 opened on Jun 11, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C (1,138 forks)batch import
help wanted

Repository metrics

Stars
 (25,779 stars)
PR merge metrics
 (Avg merge 17d 7h) (74 merged PRs in 30d)

Description

We have had a recent string of issues with regressions being introduced into the daily rest run, that weren't being caught in the daily. After reviewing the daily failures, me and some other contributors came up with the following recommendation.

  1. Add in a second test suite that uses an allocator that is not jemalloc that has "no malloc size" enabled.
  2. Add a new CI target tests with TLS, but skip all of the "slow" tests. Included here is that we should add a slow tag to the payload fuzzer as they take a significant amount of time with TLS.
  3. Add a build target that actually builds the legacy unit test, to make sure they compile correctly.

We also discussed maybe adding in the sentinel tests as part of the build, however it wasn't clear if they regularly caught issues.

Contributor guide

Research direction
Examine the existing CI configuration and test structure. Implement the three recommendations: (1) add a second test suite using a non jemalloc allocator with 'no malloc size' enabled, (2) add a new CI target for tests with TLS, skipping slow tests (add a slow tag to the payload fuzzer), (3) add a build target that builds the legacy unit test to ensure they compile correctly.
Tech stack
c
Domain
backenddatabasetesting qa
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCCI/CD
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75