valkey-io/valkey

[BUG] PUBSUB SHARDNUMSUB doesn't return -CROSSSLOT for cross slot shard-channels

Open

#560 opened on May 27, 2024

View on GitHub
 (5 comments) (0 reactions) (1 assignee)C (1,138 forks)batch import
breaking-changebughelp wanted

Repository metrics

Stars
 (25,779 stars)
PR merge metrics
 (Avg merge 17d 7h) (74 merged PRs in 30d)

Description

Describe the bug

In cluster mode, calling this command with two channels mapping to different slots, like PUBSUB SHARDNUMSUB ch1 ch2, succeeds. It should return a -CROSSSLOT error, like any command with keys of two different slots.

To reproduce

Call the command with two channels mapping to the same node, but different cluster slots.

Expected behavior

-CROSSSLOT error reply.

Additional information

I believe it's enough to add a key specification in the command's JSON file under src/commands/. That would make the generic machinery for cluster crosslot detect the error early and return an error.

Contributor guide

Research direction
Locate the command specification JSON file for PUBSUB SHARDNUMSUB and add the missing key arguments to enable crossslot error detection.
Tech stack
c
Domain
database
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80