valkey-io/valkey-glide

Node: Test for protobuf internals should be part of internals tests and not client tests

Open

#3,947 opened on May 22, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (166 forks)auto 404
Task 🔧good first issuenode 🐢testing 🧪

Repository metrics

Stars
 (762 stars)
PR merge metrics
 (PR metrics pending)

Description

Client tests are integration tests and not unit tests, testing of protobuf encoding should not be part of client tests, but part of the internal test, and should be moved to the right component of testing.

https://github.com/valkey-io/valkey-glide/blob/main/node/tests/GlideClient.test.ts#L95

Testing them inside the integration tests introduce importing of the glide code from specific files, in areas where the glide code should be tested as one piece, and introduces a door for errors of import export.

Contributor guide

Research direction
Review the current test files in node/tests/GlideClient.test.ts and identify the protobuf internal tests. Move those tests to a new or existing test file in the internal test directory, ensuring all imports are correctly updated and no existing functionality is broken.
Tech stack
typescriptnodejs
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85