validatorjs/validator.js

Feature Request: Currency: Option to Require Thousands Separator

Open

#912 opened on Oct 15, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (22,497 stars) (2,253 forks)batch import
good first issuehelp neededpr-raised🙋‍♂️feature-request

Description

We're using this to help validate data that includes currency. We want to make sure that a comma separator is always present.

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptregex
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the existing `isCurrency` function in validator.js (likely in `src/lib/isCurrency.js`). The request is to add an option to require a thousands separator (comma). Look at the current implementation and its options. Discuss in the issue comments (7 comments) for any proposed solutions. Modify the function to accept a `require thousands separator` boolean and update tests accordingly.