validatorjs/validator.js

Missing validation for Macedonian phone numbers

Open

#2497 opened on Nov 14, 2024

View on GitHub
 (11 comments) (0 reactions) (1 assignee)JavaScript (22,497 stars) (2,253 forks)batch import
good first issuepr-raised🐛 bug

Description

Explanation validator.isMobilePhone cannot validate a good (valid) Macedonian phone number.

The macedonian number starts with +389, and is followed by 8 digits, or if written with national prefix (0), it will be 9 digits in length.

Additional context Validator.js version: v.13.11.0 Node.js version: v23.1.0

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptregex
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests adding support for Macedonian phone numbers to the `isMobilePhone` validator. The codebase has a locale map in `src/lib/isMobilePhone.js`. You need to add a new locale key 'any' or 'mk' with a regex pattern covering +389 followed by 8 digits or 0 followed by 9 digits, and possibly variations with spaces or dashes. Check existing locales for patterns, and add corresponding tests in `test/validators.js`. Since the issue is assigned, coordinate with the assignee or maintainers before proceeding.