validatorjs/validator.js

Missing validation for Macedonian phone numbers

Open

#2,497 opened on Nov 14, 2024

View on GitHub
 (12 comments) (0 reactions) (1 assignee)JavaScript (2,253 forks)batch import
good first issuepr-raised🐛 bug

Repository metrics

Stars
 (22,497 stars)
PR merge metrics
 (Avg merge 10h 14m) (2 merged PRs in 30d)

Description

Explanation validator.isMobilePhone cannot validate a good (valid) Macedonian phone number.

The macedonian number starts with +389, and is followed by 8 digits, or if written with national prefix (0), it will be 9 digits in length.

Additional context Validator.js version: v.13.11.0 Node.js version: v23.1.0

Contributor guide

Research direction
Review the isMobilePhone function and its test file. Add a new locale for Macedonia (MK) with regex matching +389 followed by 8 digits or 0 followed by 9 digits. Write tests for valid and invalid numbers and run the existing test suite.
Tech stack
javascript
Domain
full stack
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptregexGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80