Consider replacing jchardet by juniversalchardet

Open
#95 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
build-system

Research direction

Start by locating the htmlparser dependency declaration and the code that uses jchardet.jar. Compare that integration with juniversalchardet's README and check the existing parser tests. Done means htmlparser uses juniversalchardet without regressions and no longer requires jchardet, including for Debian's packaging case.

Written by the indexing model from the issue text.

Description

At the moment, htmlparser depends on jchardet.jar to work.

Would you consider replacing it by juniversalchardet ?

Debian (and derivatives like ubuntu) doesn't ship jchardet but ships juniversalchardet. And htmlparser is a dependency of vnu.

Distributions covering each:

According to the readme, it should fit.

At the moment, the Debian package of htmlparser removes chardet https://sources.debian.org/src/libhtml5parser-java/1.4%2Br1.3.1-3/debian/patches/no-chardet.patch/

Dominant language
Java
Stars
65
Forks
29
Avg merge
11d 21h
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from validator/htmlparser

All issues in validator/htmlparser

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.