valeriansaliou/sonic

Make all commands ASYNC (dispatch to worker thread pool)

Open

#43 opened on Mar 15, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Rust (21,176 stars) (613 forks)batch import
enhancementhelp wanted

Description

Currently, commands are processed synchronously in the channel thread. This limits parallelization on setups that open very few Sonic Channel instances, but where Sonic runs on a lot of CPUs. Currently 1 channel = 1 thread; but we'd like to make the channel protocol fully asynchronous and thus Sonic will be able to dispatch commands for work to a thread pool.

We just need to figure out how we can rework the protocol so that a RES for a REQ can be caught later on (eg. with a marker ID as we already do for search queries with PENDING?).

Contributor guide

Tech stack
rust
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Rust asyncKnowledge of Sonic channel protocol
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Examine the current channel thread implementation in Sonic's source code (likely in src/channel or similar). Understand how REQ/RES are matched. Consider using marker IDs similar to search's PENDING mechanism to associate responses with requests. Propose a design that uses Rust's async/await and a thread pool.