vadimdemedes/mongorito

query.lte overwrites query.gte and vice versa

Open

#104 opened on Apr 10, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (104 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,397 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It seems like query.lte overwrites query.gte and vice versa. Steps to reproduce:

const Model = require('mongorito').Model; let query = Model.gte('updated_at', new Date()); query = Model.lte('updated_at', new Date()); console.log(query.query); // { created_at: { '$lte': Sun Apr 10 2016 11:09:32 GMT+0200 (CEST) } }

Contributor guide

Research direction
Examine the setter methods for gte and lte in the query builder. They likely override each other because they both target a single key in the query object. Consider fixing by storing both in nested objects like `{ field: { $gte: ..., $lte: ... } }`.
Tech stack
javascriptnodejsmongodb
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptMongoDB
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75