vadimdemedes/mongorito

query.lte overwrites query.gte and vice versa

Open

#104 opened on Apr 10, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,397 stars) (104 forks)batch import
bughelp wanted

Description

It seems like query.lte overwrites query.gte and vice versa. Steps to reproduce:

const Model = require('mongorito').Model; let query = Model.gte('updated_at', new Date()); query = Model.lte('updated_at', new Date()); console.log(query.query); // { created_at: { '$lte': Sun Apr 10 2016 11:09:32 GMT+0200 (CEST) } }

Contributor guide

Tech stack
javascriptnodejsmongodb
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basicsMongoDB query syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug is in the query builder methods `gte` and `lte` in mongorito, likely in `lib/model.js` or similar. Currently, each method overwrites the other's condition in the query object. The fix should ensure that both conditions are stored separately, such as merging into an existing `$and` array or using separate keys. Review the source code in the repository to understand the query construction and implement a solution that correctly combines both `$gte` and `$lte` operators in the same query.