vadimdemedes/ink-ui

Status message and alert components have incorrect spacing after icon

Open

#11 opened on May 22, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,016 stars) (33 forks)user submission
bughelp wanted

Description

Seems to be caused by changes in Ink 5.

Contributor guide

Tech stack
typescriptreactnodejs
Domain
clifrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Ink CLI frameworkTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue reports incorrect spacing after icons in the alert and status message components due to changes in Ink 5. Start by examining the test files linked in the description: test/alert.tsx lines 100-128 and test/status message.tsx lines 41-52 to understand expected behavior. Then inspect the corresponding source components (likely in src/alert and src/status message) to identify where spacing is applied. Look for any recent updates to Ink v5 that may have altered default spacing or layout. The fix likely involves adjusting padding, margin, or flex properties in the component styles.