vadimdemedes/gifi

Migrate to term-img module

Open

#27 opened on Mar 9, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,025 stars) (42 forks)batch import
enhancementhelp wanted

Description

Would be way better to use a module (https://github.com/sindresorhus/term-img) for outputting GIFs, rather than spawning a new process and piping data from it.

Contributor guide

Tech stack
javascript
Domain
cli
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jschild process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue suggests replacing the current GIF output implementation (which spawns a child process and pipes data) with the 'term img' npm module. First, review the current code in gifi, likely in the main script where child process.spawn is used to output GIFs. Then, install and explore the term img module (https://github.com/sindresorhus/term img) to understand its API. The migration involves replacing the spawn logic with term img render function. Ensure the GIF file path is correctly passed and the module handles terminal output properly. No additional dependencies or complex logic are needed, making this a straightforward refactor.