vadimdemedes/dom-chef

Support camelCase props

Open

#72 opened on Sep 28, 2020

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (13 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (531 stars)
PR merge metrics
 (PR metrics pending)

Description

dom-chef sets the attributes:

https://github.com/vadimdemedes/dom-chef/blob/99adeb64de6eefbc5ccd7fecd449d34c4153c291/index.ts#L77

but as far as I know JSX works with properties, not attributes: https://reactjs.org/docs/dom-elements.html#all-supported-html-attributes

This specifically breaks SVG attributes like: <line strokeWidth={1}> It could be written as <line stroke-width={1}> but then you'd also have to customize the TypeScript types

I think the code should be changed to set the property if it's available, but I don't know if this is "magic". React likely has a list of properties instead (I'd rather not have that)

if (name in element) {
  element[name] = value;
} else {
  element.setAttribute(name, value);
}

Contributor guide

Research direction
Modify the attribute setting logic in index.ts to check if the property exists on the element and use direct property assignment (`element[name] = value`) instead of `setAttribute` for those cases. Ensure proper handling for TypeScript types and consider any edge cases with SVG or other custom elements.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptJSX
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70