@hilla/react-components should be deprecated

Open
#337 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
react, typescript
Domain
frontend

Research direction

Start by reproducing the plain React import failure and inspect node_modules/@hilla/react-components/utils/createComponent.js, where the missing @lit-labs/react import is shown. Check the react-components package dependency metadata and verify that importing the package succeeds when installed in a plain React project.

Written by the indexing model from the issue text.

Description

hilla react

Importing https://www.npmjs.com/package/@hilla/react-components to a plain React project fails due to the missing @lit-labs/react library.

Full exception:

  node_modules/@hilla/react-components/utils/createComponent.js:1:32:
      1 │ import{createComponent as n}from"@lit-labs/react";window.Vaadin??={},window.Vaadin.registrations??=[],window.Vaadin.registrations.push({is:"@hilla/react-components",version:"2.3.22"...
        ╵                                 ~~~~~~~~~~~~~~~~~

react-components package should have a dependency on @lit-labs/react

Dominant language
TypeScript
Stars
18
Forks
4
Avg merge
52m
Merged PRs (30d)
7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from vaadin/react-components

All issues in vaadin/react-components

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.