Button closing PWA prompt should have aria-label

Open Beginner friendly
#7,610 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
70/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
html
Domain
accessibility, frontend

Research direction

Open flow-server/src/main/resources/com/vaadin/flow/server/default-pwa-prompt.html at the referenced lines and inspect the close button. Run the Lighthouse audit for Bakery to confirm the accessibility finding; done means the button has an accessible aria-label such as "Dismiss" or "Close" and the audit no longer reports this issue.

Written by the indexing model from the issue text.

Description

enhancement

The "close" button in PWA install prompt is not accessible:

https://github.com/vaadin/flow/blob/248c5c39f25f73504d3f30315f407a58d113072d/flow-server/src/main/resources/com/vaadin/flow/server/default-pwa-prompt.html#L9-L13

Can be reproduced by running Lighthouse audit for Bakery:

a11y

An easy fix should be to add aria-label="Dismiss" (or "Close").

Dominant language
Java
Stars
754
Forks
219
Avg merge
21h 28m
Merged PRs (30d)
420

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from vaadin/flow

All issues in vaadin/flow

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.