Un-deprecate constructor

Open
#32 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
42/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript

Research direction

Start by locating the ExampleDataGenerator constructor taking Class type and compare its deprecation status with the overload taking Class type and LocalDateTime referenceTime. Remove the deprecation from the simpler constructor, then verify that the two constructor signatures remain available and that the project tests pass.

Written by the indexing model from the issue text.

Description

Consider un-deprecating the constructor public ExampleDataGenerator(Class<T> type).

This is deprecated in favor of public ExampleDataGenerator(Class<T> type, LocalDateTime referenceTime). However, the former is simpler to use if one doesn't want to generate date-time data, or if one doesn't care about the reference time used.

Dominant language
TypeScript
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from vaadin/example-data

All issues in vaadin/example-data

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.