uutils/coreutils

rm --one-file-system should fail wih `rm: skipping 'a/b', since it's on a different device`

Open

#7,011 opened on Dec 28, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (23,246 stars) (1,852 forks)batch import
U - rmgood first issue

Description

t=/tmp/a2323
mkdir -p a/b $t/y
sudo mount --bind $t a/b
../gnu/src/rm --one-file-system -rf a
./target/debug/coreutils rm --one-file-system -rf a
sudo umount a/b /tmp/a2323

currently returns: rm: cannot remove 'a': Device or resource busy (os error 16)

when it should return: rm: skipping 'a/b', since it's on a different device

it will probably requires a new function to investigate all files/directories to be removed. (fortunately, will be only called with --one-file-system)

Note that it should not regress:

mkdir -p a42/b
./target/debug/coreutils rm --one-file-system -rf a42 || fail=1
echo $fail

tested by upstream: bash util/run-gnu-test.sh tests/rm/one-file-system.sh tests/rm/one-file-system2

Contributor guide

Tech stack
rust
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingcoreutils rm commandfile system mountsunderstanding of one file system flag
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the current implementation of the ` one file system` flag in the `rm` command (likely in `src/uu/rm/`). The current behavior returns an OS error when encountering a mounted directory. Implement a new function that checks each target directory and skips those on different devices, emitting the expected message. Ensure the change does not regress the simple case where no mount is present. Refer to the upstream GNU coreutils behavior and the provided test scripts (tests/rm/one file system.sh) for verification.