uutils/coreutils

replace some code by https://crates.io/crates/version-compare

Open

#4,606 opened on Mar 24, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (23,246 stars) (1,852 forks)batch import
U - lsU - sortgood first issue

Description

https://github.com/uutils/coreutils/blob/main/src/uucore/src/lib/mods/version_cmp.rs#L57 could be replaced by the crate.

See: https://github.com/uutils/coreutils/pull/4325 And: https://github.com/timvisee/version-compare/issues/27

Contributor guide

Tech stack
rust
Domain
cli
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic RustFamiliarity with Cargo dependencies
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the linked PR #4325 to understand previous attempts and maintainer feedback. Examine the crate `version compare` documentation and its API to ensure it matches the functionality in `version cmp.rs`. The replacement is straightforward, but verify any edge cases or version format differences. Start by reading the current implementation in `src/uucore/src/lib/mods/version cmp.rs` and then propose a migration to use the crate.