df: Is printing the raw string guarenteed to have the same cell width as using the lossy string?

Open Beginner friendly
#11,987 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
cli

Research direction

Start in src/uu/df/src/table.rs at lines 265-271 and inspect how the lossy string width and raw bytes are used together. Confirm whether the behavior is intentional, then document that relationship with a comment and verify the df-related tests still pass.

Written by the indexing model from the issue text.

Description

U - df

See this code:

https://github.com/uutils/coreutils/blob/30fd234e59ab76e81a8277c7d2f139942fd3a0d0/src/uu/df/src/table.rs#L265-L271

It gets the width of the lossy string but stores the raw bytes. I think this at least deserves a comment explaining this is intentional. Because it's not entirely clear to me if doing a lossy conversion may use more or less cells.

Dominant language
Rust
Stars
24.1k
Forks
2k
Avg merge
1d 4h
Merged PRs (30d)
371

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from uutils/coreutils

All issues in uutils/coreutils

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.