comments in parasplit out of date

Open Beginner friendly
#10,777 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
65/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
cli

Research direction

Find the Rust implementation of parasplit and inspect the comments containing "peek ahead" and the note about forcing fl out of scope. Update those comments so they match the current scope and refactored behavior; done means neither comment describes behavior that the code does not use.

Written by the indexing model from the issue text.

Description

U - fmt
  • "peek ahead" seems pointless
  • "need to explicitly force fl out of scope before we can call self.lines.next()" is incorrect because fl is in fact in scope when we call next(), it seems a refactoring in 01c32a5220ef036bdc1d9bae8928336a815db619 put it in scope.

cc: @tertsdiepraam

Originally posted by @xtqqczze in https://github.com/uutils/coreutils/pull/10754#discussion_r2771509208

Dominant language
Rust
Stars
24.1k
Forks
2k
Avg merge
1d 4h
Merged PRs (30d)
371

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from uutils/coreutils

All issues in uutils/coreutils

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.