usebruno/bruno

[Feature Request] Support LF line breaks as well as CRLF line breaks

Open

#326 opened on Oct 4, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (43,787 stars) (2,403 forks)batch import
good first issuehelp wantedmodule-request

Description

Currently, when a client sends LF instead of CRLF as a newline character, Bruno errors out with the following message:

Error invoking remote method 'send-http-request': Error: Parse Error: Missing expected CR after header value

Insomnia does support LF newlines, and I think Bruno should as well; RFC7230 Section 3.5 also allows for this:

Although the line terminator for the start-line and header fields is the sequence CRLF, a recipient MAY recognize a single LF as a terminator and ignore any preceding CR.

Contributor guide

Tech stack
javascriptnodejs
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the Bruno codebase for where the HTTP request parsing occurs, likely in a module that handles incoming request text. The error suggests a custom parser is being used. Investigate the 'send http request' handler to find where header parsing is done and modify it to accept LF as a valid line terminator per RFC7230 Section 3.5. Consider testing with both CRLF and LF variations.