usebruno/bruno

Close all does not close all tabs

Closed

#2,965 opened on Aug 29, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,403 forks)batch import
bughelp wantedmid-term-goal

Repository metrics

Stars
 (43,787 stars)
PR merge metrics
 (Avg merge 6d 21h) (96 merged PRs in 30d)

Description

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

Hi,

I'm using Bruno 1.26.1 and there is a useful feature "close all". But it does not close "Not found" (like after you change a request name) and collection/variable tabs.

Other close options are of course also affected like close right/left, others.

Thanks.

Best, Nikita

.bru file to reproduce the bug

No response

Screenshots/Live demo link

grafik

Contributor guide

Research direction
Investigate the tab closing logic in the tab manager component. Look at how the 'close all' function iterates over tabs and why it skips 'Not found' and collection/variable tabs. The bug appears to be in the condition that determines which tabs are closed. Check the relevant state management file (e.g., tabStore.js) and the closeAll function implementation. Ensure no other close functions (close left/right) are similarly affected.
Tech stack
javascriptreactelectron
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
basic JavaScriptfamiliarity with Bruno UI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65