cleanup bug : createReexecCmd: dead if logLevel != "" guard around _LIBCONTAINER_LOGLEVEL
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 82/100
Research direction
Open cmd/urunc/create.go and inspect createReexecCmd, focusing on how _LIBCONTAINER_LOGLEVEL is added to reexecCommand.Env. Confirm the conversion always produces a non-empty value, then simplify the dead conditional and run the relevant Go tests to ensure re-exec command construction still passes.
Written by the indexing model from the issue text.
Description
In createReexecCmd (cmd/urunc/create.go), the log level env var is gated on a condition that can never be false:
logLevel := strconv.Itoa(int(logrus.GetLevel()))
if logLevel != "" {
reexecCommand.Env = append(reexecCommand.Env, "_LIBCONTAINER_LOGLEVEL="+logLevel)
}
strconv.Itoa always returns a non-empty string . so logLevel != "" is always true and the guard is dead code
not a functionality bug only a cleanup issue .
- Dominant language
- Go
- Stars
- 298
- Forks
- 202
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 28
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from urunc-dev/urunc
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
do-not-merge invalid
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·