handleQueueProxy may append empty env var

Open Beginner friendly
#419 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go
Domain
infrastructure

Research direction

Start in utils.go at handleQueueProxy and trace how SERVING_READINESS_PROBE is read and added to spec.Process.Env. Reproduce the queue-proxy container without that variable, then verify the environment list no longer contains an empty entry when the variable is absent.

Written by the indexing model from the issue text.

Description

Stale

Location: utils.go
If SERVING_READINESS_PROBE isn’t found, readinessProbeEnv remains empty and gets appended to spec.Process.Env, creating an empty env entry.

Steps to reproduce:

  • Run queue-proxy container without SERVING_READINESS_PROBE env.
  • Observe env list contains empty string.

Suggested fix: only append readinessProbeEnv when non‑empty.

Dominant language
Go
Stars
298
Forks
202
Avg merge
2d 18h
Merged PRs (30d)
28

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from urunc-dev/urunc

All issues in urunc-dev/urunc

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.