unoplatform/uno

[Skia] Restore Runtime Tests

Open

#7,271 opened on Oct 4, 2021

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C# (837 forks)batch import
area/items-repeaterarea/skia ✏️area/skia/stability ✏️area/tests 🧪difficulty/starter 🚀good first issuekind/bugno-reproproject/core-tools 🛠️

Repository metrics

Stars
 (9,789 stars)
PR merge metrics
 (Avg merge 14d 8h) (130 merged PRs in 30d)

Description

Current behavior

After the introduction of Skia runtime tests, the following runtime tests are failing:

  • ValidateLayoutRoundingForPixelDimensions
  • CanReplaceSingleItem
  • When_CloseLast_Then_FileDeleted
  • Should_Close_Open_Popups
  • When_TransformToVisual_WithMargin
  • When_MinWidth_SmallerThan_AvailableSize (#14368)
  • TestVariousArrangedPosition
  • When_ProgressRing_Visible
  • When_Calling_Select_With_Negative_Values
  • When_Calling_Select_With_In_Range_Values
  • When_Calling_Select_With_Out_Of_Range_Length
  • When_Calling_Select_With_Out_Of_Range_Start
  • When_Nested_In_Native_View

Those tests are now ignore in order to stabilize existing passing tests.

Expected behavior

The tests pass.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

3.11-dev

Affected platforms

Skia (GTK on Linux/macOS/Windows)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

Contributor guide

Research direction
Examine the failing test cases listed in the issue, identify the root cause by running them locally with Skia backend, and fix each one. Start with the unchecked ones: CanReplaceSingleItem and When MinWidth SmallerThan AvailableSize. Refer to the linked PR #14368 for context.
Tech stack
csharp
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65