unoplatform/uno

[WASM] Use `manifest.json` for `PackageId.Version`

Open

#6,420 opened on Jul 7, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C# (837 forks)batch import
difficulty/medium 🤔good first issuekind/enhancementno-reproplatform/wasm 🌐project/non-ui ⚙️

Repository metrics

Stars
 (9,789 stars)
PR merge metrics
 (Avg merge 14d 8h) (130 merged PRs in 30d)

Description

What would you like to be added:

If the app has a manifest.json, we should use its version property (if it is defined) for PackageId.Version as opposed to Assembly version.

Why is this needed:

To verify running application version

For which Platform:

  • [ x] iOS
  • [ x] Android
  • [ x] WebAssembly
  • [ x] WebAssembly renderers for Xamarin.Forms
  • [ x] macOS
  • [ x] Skia
    • [x ] WPF
    • [ x] GTK (Linux)
    • [ x] Tizen
  • [ x] Windows
  • Build tasks
  • Solution Templates

Anything else we need to know?

It seems like an odd thing to not be implemented.

Contributor guide

Research direction
Look at how PackageId.Version is currently set in the Uno project. Modify the build process to read version from manifest.json if present, falling back to Assembly version.
Tech stack
csharpwasm
Domain
mobiledesktopweb dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#Uno Platform basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50