unoplatform/uno

Enable more `NavigationView` runtime/UI tests

Open

#4,769 opened on Dec 19, 2020

View on GitHub
 (5 comments) (0 reactions) (1 assignee)C# (837 forks)batch import
area/navigationview 🧭difficulty/medium 🤔good first issuekind/enhancementno-reproproject/layout 🧱

Repository metrics

Stars
 (9,789 stars)
PR merge metrics
 (Avg merge 14d 8h) (130 merged PRs in 30d)

Description

What would you like to be added:

Several NavigationView runtime tests and UI tests are now ignored either due to layout issues in the test area or due to different lifecycle.

Some of the Sample pages for WinUI NavigationView are not marked with [Sample] as they fail to open on Skia/WASM/other platforms. Seems they get stuck in a layout loop.

Why is this needed:

More coverage

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Skia
    • WPF
    • GTK (Linux)
    • Tizen
  • Windows
  • Build tasks
  • Solution Templates

Contributor guide

Research direction
Investigate the ignored NavigationView runtime and UI tests in the repository. Identify which tests are ignored, determine the root cause (layout issues or lifecycle differences), and attempt to enable them. Also, examine the NavigationView sample pages that fail on Skia/WASM to resolve layout loops.
Tech stack
csharp
Domain
mobiledesktop
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Uno PlatformXAMLTesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70